Perl::Critic::Policy::ControlStructures::ProhibitUnlessBlocks

NAME

Perl::Critic::Policy::ControlStructures::ProhibitUnlessBlocks - Write "if(! $condition)" instead of "unless($condition)".

AFFILIATION

This Policy is part of the core Perl::Critic distribution.

DESCRIPTION

Conway discourages using "unless" because it leads to double-negatives that are hard to understand. Instead, reverse the logic and use "if".

unless($condition) { do_something() } #not ok
unless(! $no_flag) { do_something() } #really bad
if( ! $condition) { do_something() } #ok

This Policy only covers the block-form of "unless". For the postfix variety, see "ProhibitPostfixControls".

CONFIGURATION

This Policy is not configurable except for the standard options.

SEE ALSO

Perl::Critic::Policy::ControlStructures::ProhibitPostfixControls

AUTHOR

Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>

COPYRIGHT

Copyright (c) 2005-2011 Imaginative Software Systems. All rights reserved.

This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module.